Archives
Archives
| From: | "Michał Górny" <mgorny@g.o> | ||
|---|---|---|---|
| To: | Mike Frysinger <vapier@g.o> | ||
| Cc: | gentoo-dev@l.g.o, toolchain@g.o | ||
| Subject: | Re: [gentoo-dev] Re: [PATCH 4/4] toolchain-funcs.eclass: Add helpful tc-is-{gcc,clang} wrappers | ||
| Date: | Fri, 24 Jun 2016 05:40:49 | ||
| Message-Id: | 20160624074021.5670f371.mgorny@gentoo.org | ||
| In Reply to: | [gentoo-dev] Re: [PATCH 4/4] toolchain-funcs.eclass: Add helpful tc-is-{gcc,clang} wrappers by Mike Frysinger |
||
| 1 | On Thu, 23 Jun 2016 21:32:34 -0400 |
| 2 | Mike Frysinger <vapier@g.o> wrote: |
| 3 | |
| 4 | > On 22 Jun 2016 22:06, Michał Górny wrote: |
| 5 | > > +# @FUNCTION: tc-is-gcc |
| 6 | > > +# @DESCRIPTION: |
| 7 | > > +# Return true if the current compiler is pure GCC. |
| 8 | > |
| 9 | > "pure" doesn't make much sense and is just confusing |
| 10 | > |
| 11 | > shouldn't this be a @RETURN instead of @DESCRIPTION ? same for clang below. |
| 12 | |
| 13 | I've followed suit with other functions in the eclass. They use @RETURN |
| 14 | for stuff that is echoed, and @DESCRIPTION for exit codes. |
| 15 | |
| 16 | -- |
| 17 | Best regards, |
| 18 | Michał Górny |
| 19 | <http://dev.gentoo.org/~mgorny/> |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Re: [PATCH 4/4] toolchain-funcs.eclass: Add helpful tc-is-{gcc,clang} wrappers | Mike Frysinger <vapier@g.o> |