| 1 |
May I suggest this minor modification. With the original code, if the |
| 2 |
same flag comes up twice as either 'disabled' or 'unset' it gets added as |
| 3 |
'enabled', since it fails the string.find() duplicate check, and there's |
| 4 |
only a dup check on the fallthrough to 'enabled'. The simple patch |
| 5 |
enclosed fixes this. |
| 6 |
|
| 7 |
Other than that, this is a great idea, works well, I'd love to see it |
| 8 |
included. |
| 9 |
|
| 10 |
-J.D. |
| 11 |
>Well, semi use aware anyway. |
| 12 |
> |
| 13 |
>What do you think? |
| 14 |
> |
| 15 |
> |
| 16 |
>$ ./emerge -p mozilla |
| 17 |
> |
| 18 |
>These are the packages that I would merge, in order: |
| 19 |
> |
| 20 |
>Calculating dependencies ...done! |
| 21 |
>[ebuild R ] net-www/mozilla-1.2.1-r4 |
| 22 |
. |
| 23 |
> |
| 24 |
>The following USE flags for this action are: |
| 25 |
> |
| 26 |
>[enabled] java crypt gtk2 ssl gnome |
| 27 |
>[disabled] ipv6 |
| 28 |
>[unset] ldap mozsvg mozcalendar mozaccess mozinterfaceinfo mozp3p |
| 29 |
>mozxmlterm moznoirc moznomail moznocompose moznoxft |
| 30 |
> |
| 31 |
<etc etc etc> |
Archives