Gentoo Archives: gentoo-dev

From: "Andreas K. Huettel" <dilfridge@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency
Date: Sat, 12 Dec 2015 20:22:18
Message-Id: 201512122122.05156.dilfridge@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 01/15] perl-module.eclass: Allow EAPI=6, ban PERL_EXPORT_PHASE_FUNCTIONS there, simplify perl dependency by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 Am Samstag, 12. Dezember 2015, 12:49:09 schrieb Michał Górny:
5 > Dnia 11 grudnia 2015 22:02:57 CET, dilfridge@g.o napisał(a):
6
7 > >+ case "${PERL_EXPORT_PHASE_FUNCTIONS:-yes}" in
8 > >+ yes)
9 > >+ EXPORT_FUNCTIONS ${PERL_EXPF}
10 > >+ ;;
11 > >+ no)
12 > >+ debug-print "PERL_EXPORT_PHASE_FUNCTIONS=no"
13 > >+ ;;
14 > >+ *)
15 > >+ die
16 "PERL_EXPORT_PHASE_FUNCTIONS=${PERL_EXPORT_PHASE_FUNCTIONS} is
17 > >not supported by perl-module.eclass"
18 > >+ ;;
19 > >+ esac
20 >
21 > You could split this move, you know.
22
23 Yeah but it's probably more useful to change behavior now and then keep it
24 consistent for whole EAPI=6...
25
26 > >+ case "${GENTOO_DEPEND_ON_PERL:-yes}" in
27 > >+ yes)
28 > >+ case "${GENTOO_DEPEND_ON_PERL_SUBSLOT:-yes}" in
29 > >+ yes)
30 > >+ DEPEND="dev-lang/perl:="
31 > >+ ;;
32 > >+ *)
33 > >+ DEPEND="dev-lang/perl"
34 > >+ ;;
35 > >+ esac
36 > >+ RDEPEND="${DEPEND}"
37 > >+ ;;
38 > >+ esac
39 >
40 > Why don't you pack this stuff into a single trinary variable?
41
42 Good idea. Let's kill GENTOO_DEPEND_ON_PERL_SUBSLOT (never liked it, too long
43 variable name :) and instead provide support for
44 GENTOO_DEPEND_ON_PERL=noslotop
45
46
47 - --
48
49 Andreas K. Huettel
50 Gentoo Linux developer
51 dilfridge@g.o
52 http://www.akhuettel.de/
53
54 -----BEGIN PGP SIGNATURE-----
55 Version: GnuPG v2.1
56
57 iQJ8BAEBCgBmBQJWbIHoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
58 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0RkJDMzI0NjNBOTIwMDY5MTQ2NkMzNDBF
59 MTM4NkZEN0VGNEI1Nzc5AAoJEOE4b9fvS1d5/NEP/RshKssht2YpkvxMzhj1wIj2
60 6ZAIWpq7lUlgaaORy/wVeGu29GVG1g5+Ov2KZdZjUVtVdG5JcRkdxihgwWL+AUT9
61 VfvEnlikEN+UTjJFE+1YmDEAynPpfAjv31UBLQg1LiKaUCHE8kABUFCJrUfmf6Pl
62 A0CkiwdGCDjeY3BFdQG4wQm/rbnMSeyMK39qodqNfKk/vwDl67LSHvifBKzuHqcJ
63 xcgKHVPNgN5T0HR6GLiBRO83PWOyQVYyX0/rMkQqTW4ggKGMHHtj15e+193sAyzX
64 ke1+yrYQtA1nLa3bwSRz/gWJkxXEPo9ZsRxPYgk1F3wM/l63hGYBQ5dR7oR2hx69
65 hoAhmwQvv4GpJoDq5Tm8//Ko+joRcFrj1yNTNmQn/KSWlX7+PE8uMrh2IoVznXb+
66 7BhWpeIx5/6txwlfGZzvdkH0KdK+Ahv0+QsKF0ZHm3S8T2fWsFLYfYR2cuC1UQYz
67 1W5vWaCUyt8nBZU7VR/+MWzyffZlwGkPmckbAxDX5CSn5EJTVs+y0PyhduYKd6RN
68 9i+8bmNHxPmehpjrs2En2iOhHiwO6q30wUTh0zY6CmNWmSsywUPlF8HSYwwScF0y
69 9C326aVegA29465gNdUw8njknwkksyUzFRBviGaB/ZzhjuA7AIvvdq/lpa3Eakhl
70 DXfw03GJDBK9cJogc2x+
71 =Zio8
72 -----END PGP SIGNATURE-----