Gentoo Archives: gentoo-dev

From: Hans de Graaff <graaff@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/3] savedconfig.eclass: Always quote filename in output
Date: Sun, 04 Aug 2019 06:24:43
Message-Id: 4e5ff606475437024cea00a4482ad712b5b08a81.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 2/3] savedconfig.eclass: Always quote filename in output by Mike Gilbert
1 On Sat, 2019-08-03 at 16:49 -0400, Mike Gilbert wrote:
2 > On Sat, Aug 3, 2019 at 12:21 PM Ulrich Mueller <ulm@g.o>
3 > wrote:
4 > > > > > > > On Sat, 03 Aug 2019, Thomas Deutschmann wrote:
5 > > > + ewarn "provide a configuration file in
6 > > > ${PORTAGE_CONFIGROOT%/}/etc/portage/savedconfig/${CATEGORY}/${PN}
7 > > > "
8 > >
9 > > Long line.
10 >
11 > How would you shorten it? Splitting it across 2 lines in the middle
12 > of
13 > the string just makes it less readable.
14
15 path="${PORTAGE_CONFIGROOT%/}/etc/portage/savedconfig/${CATEGORY}/${PN}
16 "
17 ewarn "provide a configuration file in ${path}"
18
19 Or something similar.
20
21 Hans

Attachments

File name MIME type
signature.asc application/pgp-signature