1 |
Ulrich Mueller wrote: |
2 |
|
3 |
>>>>>> On Mon, 06 Oct 2008, Jorge Manuel B S Vicetto wrote: |
4 |
> |
5 |
>> No objections here, just a question. Do you know if the issue with the |
6 |
>> lp:// sources has been fixed in bzr? |
7 |
> |
8 |
No objections, a minor point wrt bash: |
9 |
|
10 |
EBZR_OPTIONS="${EBZR_OPTIONS:-}" (and similar variants) |
11 |
doesn't do anything (beyond waste lex and yacc time.) I can understand the |
12 |
maintenance argument, but I don't think it really flies, given the |
13 |
inordinate lengths considered in the past to avoid sourcing an ebuild. |
14 |
|
15 |
The same consideration applies to all those "constant values" 'and indeed' |
16 |
${foo} as opposed to $foo, though first time I raised that I got sworn at, |
17 |
so not expecting miracles here. |
18 |
|
19 |
[[ -z ${EBZR_REPO_URI} ]] && die .. |
20 |
Here's how I'd write that: |
21 |
[[ $EBZR_REPO_URI ]] || die .. |
22 |
|
23 |
I've heard the "be explicit" argument before (hey antarus;) and here's why I |
24 |
disagree: |
25 |
If you don't know test (''help test'') and what its default is, then you |
26 |
really don't know the basics of shellscript (you possibly only think you |
27 |
do.) If you don't know shell, and can't begin to understand what that might |
28 |
do, then you shouldn't consider coding as a career, and I'd expect you to |
29 |
take quite a while to go through the #bash crucible; if you ever make it |
30 |
I'd have a lot of time for you. |
31 |
|
32 |
(Since you use || elsewhere, I don't expect to hear the "|| is cryptic even |
33 |
if we say OR in speech" argument.) |
34 |
|
35 |
I appreciate that appears like 3 or 4 points: they all come under the 'clean |
36 |
bash' heading: it runs faster, as well as being easier to read and write. |
37 |
|
38 |
> Looks like this is working fine with bzr-1.5, so I'll change the |
39 |
> dependency. |
40 |
> |
41 |
Given that, is there any reason not to use 1.6 if installed, and fallback to |
42 |
an earlier version if not? Personally I'd just use an unversioned dep in |
43 |
the latter case, given that 1.5 is stable and 1.7.1 is ~arch (amd64). |
44 |
Doesn't sound like it's going to be long to get 1.6. |
45 |
|
46 |
I'm thinking: "maximise utility before you unleash it on the tree". |