| 1 |
TL;DR: perl-module.eclass gets a well-defined and documented API. You may see |
| 2 |
some harmless "eqawarn" warnings from your ebuilds over the next time; either |
| 3 |
fix them yourself according to the warning message or just wait until the |
| 4 |
warnings are gone again. Overlay ebuilds will need to be fixed. |
| 5 |
|
| 6 |
|
| 7 |
Hi all, |
| 8 |
|
| 9 |
perl-module.eclass has grown over the years. While it contains a lot of |
| 10 |
functionality, there are also several duplicate functions and many unneeded |
| 11 |
phase definitions. [And other complications as e.g. abysmal *FLAGS handling, |
| 12 |
but that's a story for another christmas^H^H^H^H^H^H^H^H EAPI.] So, it's |
| 13 |
cleanup time. |
| 14 |
|
| 15 |
What will NOT happen: The list of *exported* phase functions will NOT change |
| 16 |
now. That's reserved for future EAPIs, e.g. for the EAPI=6 transition. So, you |
| 17 |
can be safe that inheritance order etc bla bla remains unchanged. |
| 18 |
|
| 19 |
What will happen: |
| 20 |
* Addition of documentation |
| 21 |
* Removal of duplicate functions (e.g., "perlinfo" does exactly the same as |
| 22 |
"perl_set_version") |
| 23 |
* Removal of not-exported, pointless phase functions (e.g., "perl- |
| 24 |
module_pkg_preinst" is not exported and calls only "perl_set_version" - so a |
| 25 |
call of "perl-module_pkg_preinst" can be replaced by a call of |
| 26 |
"perl_set_version"). |
| 27 |
|
| 28 |
The changes to the eclass themselves are in these steps trivial and (in my |
| 29 |
opinion) do not merit review outside the Perl team. [Protest if you think |
| 30 |
otherwise.] The proposed workflow would be |
| 31 |
* add eqawarn to duplicate, about to be removed function, add docs |
| 32 |
* fix all ebuilds in the main tree (me, perl team, anyone; roughly 100 commits |
| 33 |
I'd guess) |
| 34 |
* change eqawarn to eerror |
| 35 |
* remove duplicate function some time later |
| 36 |
|
| 37 |
Cheers, |
| 38 |
Andreas |
| 39 |
|
| 40 |
-- |
| 41 |
|
| 42 |
Andreas K. Huettel |
| 43 |
Gentoo Linux developer |
| 44 |
dilfridge@g.o |
| 45 |
http://www.akhuettel.de/ |
Archives