Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] [PATCH 1/1] profiles: unset USE=session in default/linux/make.defaults.
Date: Wed, 27 Dec 2017 00:36:39
Message-Id: 20171227003539.31869-1-mjo@gentoo.org
1 The "session" USE flag has been enabled by default for all linux
2 profiles in default/linux/make.defaults since 2010. According to the
3 comment in that file, the flag was added for dev-lang/php where
4 session support is near-critical. But, now that we have an IUSE
5 default, the global setting is redundant.
6
7 This commit drops USE=session from the default/linux profile's
8 make.defaults, and also drops the (now unnecessary) override of that
9 flag in the features/hardened profile's make.defaults.
10
11 A few other packages with "session" in IUSE will be affected by this
12 change; however, the meaning of "session" varies wildly between the
13 packages that use it. Since the meaning of "session" is dependent on
14 the package in question, within the package itself (that is, with IUSE
15 defaults) is a better place to enable this flag by default.
16
17 Closes: https://bugs.gentoo.org/635742
18 ---
19 profiles/default/linux/make.defaults | 2 +-
20 profiles/features/hardened/make.defaults | 2 +-
21 2 files changed, 2 insertions(+), 2 deletions(-)
22
23 diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
24 index 899637eb7f4..4d580b1ba06 100644
25 --- a/profiles/default/linux/make.defaults
26 +++ b/profiles/default/linux/make.defaults
27 @@ -23,7 +23,7 @@ USE="${USE} seccomp"
28 # These USE flags were originally inserted here because of PHP
29 # and were later removed by me. Reinserting the USE flags again because they are
30 # global USE flags that may be expected to be set by other packages.
31 -USE="${USE} cli pcre session"
32 +USE="${USE} cli pcre"
33
34 # 2006/03/07 - Donnie Berkholz <dberkholz@g.o>
35 # Modular X: Support direct rendering by default
36 diff --git a/profiles/features/hardened/make.defaults b/profiles/features/hardened/make.defaults
37 index f6389585334..1502b08728f 100644
38 --- a/profiles/features/hardened/make.defaults
39 +++ b/profiles/features/hardened/make.defaults
40 @@ -22,6 +22,6 @@ USE="${USE} -ptpax"
41 # We unset them so we get a clean use flag profile.
42 USE="${USE} -berkdb -gdbm -tcpd"
43 USE="${USE} -fortran"
44 -USE="${USE} -cli -session"
45 +USE="${USE} -cli"
46 USE="${USE} -dri"
47 USE="${USE} -modules"
48 --
49 2.13.6

Replies