| 1 |
On 7 February 2015 at 23:06, hasufell <hasufell@g.o> wrote: |
| 2 |
>>>> DEPEND="" |
| 3 |
>>> |
| 4 |
>>> unzip is missing from DEPEND |
| 5 |
>> |
| 6 |
>> I thought portage auto-depends on this. But I can add || ( unzip zip ) |
| 7 |
>> to be explicit. |
| 8 |
>> |
| 9 |
> |
| 10 |
> I don't know, but it's definitely not in @system. Afair we are only |
| 11 |
> allowed to omit deps from that set. |
| 12 |
|
| 13 |
OK, added. |
| 14 |
|
| 15 |
>>>> src_compile() { |
| 16 |
>>>> local my_arch |
| 17 |
>>>> use x86 && my_arch=x86-32-old |
| 18 |
>>>> use cpu_flags_x86_sse && my_arch=x86-32 |
| 19 |
>>>> use amd64 && my_arch=x86-64 |
| 20 |
>>>> use cpu_flags_x86_popcnt && my_arch=x86-64-modern |
| 21 |
>>>> use cpu_flags_x86_avx2 && my_arch=x86-64-bmi2 |
| 22 |
>>>> |
| 23 |
>>>> emake build ARCH=${my_arch} CXX="$(tc-getCXX)" CXXFLAGS="${CXXFLAGS}" |
| 24 |
>>> |
| 25 |
>>> This currently breaks all cpu flags, because it overwrites anything the |
| 26 |
>>> Makefile does to CXXFLAGS, including -msse and -DIS_64BIT and even other |
| 27 |
>>> flags that are not CPU specific (e.g. -DNDEBUG). |
| 28 |
>> |
| 29 |
>> Thanks for catching this! I guess we do need to patch the Makefile |
| 30 |
>> then, to *also* honour user-set CXXFLAGS and LDFLAGS. Or could we get |
| 31 |
>> away with just letting the Makefile do its thing? |
| 32 |
>> |
| 33 |
> |
| 34 |
> I've hit this bug myself in my overlay... I'll probably get up a pull |
| 35 |
> request upstream today. |
| 36 |
|
| 37 |
I think it's okay now. They do += so the user cxxflags and ldflags do |
| 38 |
get honoured, but they end their own flags at the end of it. I've |
| 39 |
added some more configuration options to the ebuild (optimize and |
| 40 |
debug are important here). |
| 41 |
|
| 42 |
-- |
| 43 |
Cheers, |
| 44 |
|
| 45 |
Ben | yngwin |
| 46 |
Gentoo developer |
Archives