Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] epatch.eclass: call ebegin to balance eend
Date: Tue, 28 Jun 2022 06:05:56
Message-Id: uwnd1l3uz@gentoo.org
In Reply to: [gentoo-dev] [PATCH] epatch.eclass: call ebegin to balance eend by Mike Gilbert
1 >>>>> On Mon, 27 Jun 2022, Mike Gilbert wrote:
2
3 > if [[ ${SINGLE_PATCH} == "yes" ]] ; then
4 > if [[ -n ${EPATCH_SINGLE_MSG} ]] ; then
5 > - einfo "${EPATCH_SINGLE_MSG}"
6 > + ebegin "${EPATCH_SINGLE_MSG}"
7 > else
8 > - einfo "Applying ${patchname} ..."
9 > + ebegin "Applying ${patchname}"
10 > fi
11
12 EPATCH_SINGLE_MSG isn't used in the tree, so this could be simplified to
13 have the "else" part only, and delete the eclass variable. (Strange idea
14 to make this message configurable, in the first place.)
15
16 > else
17 > - einfo " ${patchname} ..."
18 > + ebegin " ${patchname}"
19 > fi
20
21 Maybe drop support for EAPIs 0 to 4 while at it?
22
23 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies