1 |
On Saturday 15 September 2007, Donnie Berkholz wrote: |
2 |
> On 16:52 Sat 15 Sep , Mike Frysinger wrote: |
3 |
> > On Saturday 15 September 2007, Donnie Berkholz wrote: |
4 |
> > > On 05:56 Sat 15 Sep , Mike Frysinger wrote: |
5 |
> > > > On Saturday 15 September 2007, Donnie Berkholz wrote: |
6 |
> > > > > Also, try using { } around a block of code instead of ( ), which |
7 |
> > > > > creates a subshell. |
8 |
> > > > |
9 |
> > > > erm, what ? () is a subshell, {} is a list of grouped commands ... |
10 |
> > > |
11 |
> > > Right, that's what I said. What's the point of using a subshell here? |
12 |
> > > That comment about environment pollution didn't make sense to me. |
13 |
> > |
14 |
> > the "into" part pollutes the environment |
15 |
> |
16 |
> One insinto definitely doesn't qualify as pollution to me. Mild |
17 |
> littering, perhaps. But with a subshell, it's only a matter of time |
18 |
> before something weird happens, like trying to put a die() in there. |
19 |
|
20 |
i dont use the eclass so it doesnt matter to me, but it does modify the |
21 |
environment in possibly unexpected ways for the caller |
22 |
|
23 |
for do* funcs this is a must, for other funcs it's up to the maintainers |
24 |
-mike |