Re: [gentoo-dev] [PATCH] bzr.eclass: Drop bzr_bootstrap and bzr_src_prepare.

[Ulrich Mueller]

>>>>> On Wed, 07 Feb 2018, Michał Górny wrote:

>> -# @FUNCTION: bzr_src_prepare
>> -# @DESCRIPTION:
>> -# Default src_prepare(), calls bzr_bootstrap.
>> -bzr_src_prepare() {
>> -	bzr_bootstrap
>> }

> Hmm, unless I'm mistaken, this can cause another definition
> of src_prepare to start applying to ebuilds.

That's right, but wasn't relying on inherit order considered a QA
violation? In other words, shouldn't an ebuild define an explicit
phase function if it inherits more than one eclass exporting that
function?

> You can submit a PR with this change to get md5-cache with exported
> phase data suitable for comparison.

> Or... given the popularity of the eclass, you can check by hand ;-P.

Done so for the Gentoo repo (before posting the patch). Or rather,
I have checked that WORKDIR has identical contents after the prepare
phase.

Ulrich