Re: mercurial.eclass (was: [gentoo-dev] New darcs.eclass)

[Matthias Schwarzott]

On Saturday 20 May 2006 15:23, Aron Griffis wrote:
> Henrik Brix Andersen wrote: [Sat May 20 2006, 04:50:22AM EDT]
>
> > On Fri, May 19, 2006 at 10:36:42PM -0400, Aron Griffis wrote:
> > > Along these lines, I added my mercurial.eclass to the tree.  I use it
> > > personally for a couple projects, and figured it might help prevent
> > > other people from needing to re-invent the wheel.
> >
> > Errr... you added a new eclass without posting it to this mailing
> > list for review first?
>
> I've never posted an eclass here for review, and I don't think I've
> ever announced one before either, so let's call this progress. ;-)
>
> If you'd like to review it, I'd appreciate the input.
>

I am in the process of creating the ebuild v4l-dvb-hg to compile the sources 
for the development-dvb-driver.

I have a few annotations for mercurial.eclass:
* The eclass copies the downloaded sources to ${S} rather than to 
${WORKDIR}/${HG_MODULE_NAME}.
So I have to use
S=${WORKDIR}/xyz to unpack it there and have S set to a subdirectory of the 
hg-sources.

* the unpack-function keeps the current working directory 
in /usr/portage/distfiles/hg-src/${HG_MODULE}.
That creates problems when applying patches.
Could the eclass switch to ${WORKDIR} after unpacking.


Now I use this part of code

S=${WORKDIR}/v4l-dvb/v4l
src_unpack() {
    S=${WORKDIR}/v4l-dvb mercurial_src_unpack
    cd ${WORKDIR}
    epatch ...
}

Regards
  Matthias

-- 
Matthias Schwarzott
Gentoo Developer
http://www.gentoo.org
-- 
gentoo-dev@g.o mailing list