Gentoo Archives: gentoo-dev

From: Duncan <1i5t5.duncan@×××.net>
To: gentoo-dev@l.g.o
Cc: gentoo-java@l.g.o
Subject: [gentoo-dev] Re: [PATCH] ant-tasks.eclass: use eapi7-ver
Date: Tue, 22 May 2018 07:59:18
Message-Id: pan$9ed4c$5f902e85$1977f678$426817f0@cox.net
In Reply to: Re: [gentoo-dev] Re: [PATCH] ant-tasks.eclass: use eapi7-ver by "Marty E. Plummer"
1 Marty E. Plummer posted on Mon, 21 May 2018 23:01:10 -0500 as excerpted:
2
3 >> > +[[ ${EAPI} == 7 ]] || inherit eapi7-ver
4 >>
5 >> Always check for old EAPIs, instead of expecting people to keep
6 >> updating this forever.
7 >>
8 > Would you prefer something like [[ ${EAPI} ~= [0-6] ]] && inherit
9 > eapi7-ver, then?
10 > The way I see it, every consumer of ant-tasks is eapi 5 right now, 5 and
11 > 6 if my pull request is accepted. Once every consumer is eapi 7 or
12 > greater,
13 > this line can be removed entirely and it won't be needing updates
14 > 'forever'.
15
16 Test defensively. We're not just talking EAPI=8, etc, here. What
17 happens if someone typos EAPI=56 or some such? Positively support what
18 you recognize. If it's unrecognized, it should always fall thru to an
19 error saying it's unsupported. Much easier to debug that way. =:^)
20
21 --
22 Duncan - List replies preferred. No HTML msgs.
23 "Every nonfree program has a lord, a master --
24 and if you use the program, he is your master." Richard Stallman