Gentoo Archives: gentoo-dev

From: David Seifert <soap@g.o>
To: gentoo-dev@l.g.o
Cc: haskell@g.o, slyfox@g.o, Michael Haubenwallner <haubi@g.o>
Subject: Re: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7
Date: Wed, 29 May 2019 09:04:11
Message-Id: 44a6d9beef596ffd2135c182a008a4d9474dd652.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] darcs.eclass: use BDEPEND with EAPI >= 7 by Michael Haubenwallner
1 On Wed, 2019-05-29 at 11:00 +0200, Michael Haubenwallner wrote:
2 > ---
3 > eclass/darcs.eclass | 12 ++++++++++--
4 > 1 file changed, 10 insertions(+), 2 deletions(-)
5 >
6 > diff --git a/eclass/darcs.eclass b/eclass/darcs.eclass
7 > index 489008a87f1..81003651680 100644
8 > --- a/eclass/darcs.eclass
9 > +++ b/eclass/darcs.eclass
10 > @@ -85,8 +85,16 @@ SRC_URI=""
11 >
12 > # --- end ebuild-configurable settings ---
13 >
14 > -DEPEND="dev-vcs/darcs
15 > - net-misc/rsync"
16 > +case ${EAPI:-0} in
17 > + [0-6]*)
18
19 Why the *? Do we really care about EAPI="5-HDEPEND" and others?
20
21 > + DEPEND="dev-vcs/darcs
22 > + net-misc/rsync"
23 > + ;;
24 > + *)
25 > + BDEPEND="dev-vcs/darcs
26 > + net-misc/rsync"
27 > + ;;
28 > +esac
29 >
30 > # @FUNCTION: darcs_patchcount
31 > # @DESCRIPTION:
32
33 Might be worth thinking about adding an EAPI whitelist like we do for
34 other eclasses. Just an idea, not required.

Replies