1 |
On Wednesday 25 January 2006 20:46, Brian Harring wrote: |
2 |
> On Wed, Jan 25, 2006 at 08:27:22PM +0900, Jason Stubbs wrote: |
3 |
> > On Wednesday 25 January 2006 18:10, Donnie Berkholz wrote: |
4 |
> > > Jason Stubbs wrote: |
5 |
> > > > DEPEND="x11-base/xorg-x11" # wrong |
6 |
> > > > DEPEND="virtual/x11" # wrong |
7 |
> > > > DEPEND="|| ( x11? ( virtual/x11 ) )" # wrong |
8 |
> > > > DEPEND="|| ( misc/atoms virtual/x11 )" # right |
9 |
> > > > |
10 |
> > > > There's a small possibility that broken packages will be missed by |
11 |
> > > > this, but is there any chance that valid packages will be incorrectly |
12 |
> > > > flagged? If this gets a go-ahead, it'll be easy enough to get in for |
13 |
> > > > the next release (which is likely this coming Saturday). |
14 |
> > > |
15 |
> > > It sounds right. There should be no valid instance of virtual/x11 that |
16 |
> > > is not within an || dep. |
17 |
> > |
18 |
> > I've implemented and tested the check locally but haven't committed it |
19 |
> > yet. Repoman isn't really structured to allow for tests against a set of |
20 |
> > ebuilds so the checks are done on every version. There is also definitely |
21 |
> > one false positive (virtual/x11-6.8) so, for this and the fact that every |
22 |
> > version is tested, it would probably better to just make it a warning. |
23 |
> > Thoughts? |
24 |
> |
25 |
> Curious about the mechanism you're using for this... a hardcoded set |
26 |
> of atoms in repoman doesn't sound very nice to me ;) |
27 |
|
28 |
Get off it. There's no other way to do it given repoman's state and the |
29 |
requirements. If you'd like to make repoman pluggable, convert all the |
30 |
current checks to plugins and then make a new plugin for this one and do it |
31 |
all by this weekend, be my guest. :P |
32 |
|
33 |
Besides, what's wrong with hardcoded atoms in repoman anyway? Repoman doesn't |
34 |
have to stand the test of time. Conversely, it should represent checks for |
35 |
whatever issues are present in the tree at the time of its release. |
36 |
|
37 |
http://dev.gentoo.org/~jstubbs/x11_deprecation_check.diff |
38 |
|
39 |
-- |
40 |
Jason Stubbs |
41 |
-- |
42 |
gentoo-dev@g.o mailing list |