Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fix py-compile script
Date: Fri, 29 Jul 2022 12:59:24
Message-Id: u35ekvzvm@gentoo.org
In Reply to: [gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fix py-compile script by "Michał Górny"
1 >>>>> On Fri, 29 Jul 2022, Michał Górny wrote:
2
3 > --- a/net-wireless/blueman/blueman-2.3.1.ebuild
4 > +++ b/net-wireless/blueman/blueman-2.3.1.ebuild
5 > @@ -97,7 +97,7 @@ pkg_setup() {
6 > }
7 >
8 > src_prepare() {
9 > - [[ ${PV} == 9999 ]] && eautoreconf
10 > + [[ ${PV} == 9999 ]] && eautoreconf || eautomake
11
12 So if eautoreconf returns with nonzero status, eautomake will be called?
13 Or does eautoreconf always return zero (I believe it does)?
14
15 However, I don't want to think about that when reading the code, so
16 could you make it an if-then-else statement instead?
17
18 Same for the live ebuild.
19
20 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature