Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: David Seifert <soap@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass
Date: Sun, 06 Sep 2020 19:49:54
Message-Id: utuwahei4@gentoo.org
In Reply to: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass by David Seifert
1 >>>>> On Sun, 06 Sep 2020, David Seifert wrote:
2
3 > @@ -20,7 +20,7 @@ _EUTILS_ECLASS=1
4 > # implicitly inherited (now split) eclasses
5 > case ${EAPI:-0} in
6 > 0|1|2|3|4|5|6)
7 > - inherit desktop epatch estack ltprune multilib preserve-libs \
8 > + inherit desktop epatch estack ltprune multilib optfeature preserve-libs \
9 > toolchain-funcs vcs-clean
10 > ;;
11 > esac
12
13 I count 163 ebuilds calling optfeature in EAPI 7, but only 24 in older
14 EAPIs, which makes me wonder if the conditional inherit makes any sense.
15
16 Maybe just commit the new eclass, update ebuilds, then remove the
17 function from eutils?
18
19 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies