| 1 |
On Sat, Jan 7, 2017 at 10:07 AM, Benda Xu <heroxbd@g.o> wrote: |
| 2 |
> Hi, |
| 3 |
> |
| 4 |
> Please help me review the patch attached. |
| 5 |
|
| 6 |
Please send patches for review with the content as the email body. See |
| 7 |
git format-patch and git send-email. |
| 8 |
|
| 9 |
> This patch has 5 main kinds of modifications to the eclass, |
| 10 |
> |
| 11 |
> * Define ED and EROOT for EAPI 0, 1 and 2. |
| 12 |
> * Add ${EPREFIX} to ${PREFIX} and quote the variables. |
| 13 |
> * Strip ${EPREFIX} if used with a ebuild helper. |
| 14 |
> * call fix_libtool_files.sh by name, because /usr/sbin is in PATH, |
| 15 |
> and no need to write as ${EPREFIX}/usr/sbin/fix_libtool_files.sh |
| 16 |
> * Preserve PATH when calling gcc-config. |
| 17 |
|
| 18 |
You should split these changes into separate patches, each with it's |
| 19 |
own meaningful commit message. |
| 20 |
|
| 21 |
Regarding the PATH/gcc-config change, I'm thinking it would make more |
| 22 |
sense to drop the env -i command than to add to he list of special |
| 23 |
variables we pass through to it. |
Archives