Re: [gentoo-dev] evar_push/pop helpers

[Mike Frysinger]

On Sunday 02 June 2013 03:48:17 Tom Wijsman wrote:
> On Sun, 2 Jun 2013 03:29:33 -0400 Mike Frysinger wrote:
> > except you aren't handling edge cases (like set vs unset)
>
> You've got me there, though this is quite an exception; I don't see
> why we have to introduce something that's barely used...
>
> `qgrep -eH '^\s*\bset\b' | wc -l`
> yields 150
>
> `qgrep -eH '^\s*\bset\b' | sed 's/:.*//g' | sed
> 's/\/[a-zA-Z0-9_.-]*$//g' | sort -u | wc -l`
> yields 34
>
> Only 34 packages, and do these all _really_ need a 'set'? I doubt it.

i've got at least 4 consumers in mind, and that's more than enough imo to 
implement it right than half-ass it every time

> > > Much like fixing tiny bug and trying to
> > > avoid checking whether anything else is affected.
> >
> > yeah, because forcing specific behavior for an entire function is
> > always the correct answer.  it's like telling people to export
> > LC_ALL=C in make.conf so they never hit locale related problems.
>
> Actually, bug wranglers stopped asked for English build logs because
> setting LC_ALL=C ended up breaking things.

i know it doesn't work which is why i was providing it as an example
-mike