1 |
El vie, 15-06-2012 a las 09:03 +0200, Pacho Ramos escribió: |
2 |
> El mar, 12-06-2012 a las 23:02 -0400, Mike Frysinger escribió: |
3 |
> > i've noticed a growing trend where people put setup of variables into |
4 |
> > pkg_setup that only matter to src_* funcs presumably so they don't have to |
5 |
> > call the respective src_* func from an inherited eclass. unfortunately this |
6 |
> > adds pointless overhead to binpkgs. can we please move away from this |
7 |
> > practice ? |
8 |
> > |
9 |
> > i've seen this with a good number of the GNOME packages like: |
10 |
> > pkg_setup() { |
11 |
> > G2CONF="${G2CONF} |
12 |
> > --disable-bash-completion |
13 |
> > --disable-hal |
14 |
> > --disable-schemas-compile |
15 |
> > --with-dbus-service-dir=/usr/share/dbus-1/services |
16 |
> > $(use_enable afp) |
17 |
> > $(use_enable archive) |
18 |
> > $(use_enable avahi) |
19 |
> > $(use_enable bluetooth obexftp) |
20 |
> > $(use_enable bluray) |
21 |
> > $(use_enable cdda) |
22 |
> > $(use_enable fuse) |
23 |
> > $(use_enable gdu) |
24 |
> > $(use_enable gphoto2) |
25 |
> > $(use_enable ios afc) |
26 |
> > $(use_enable udev) |
27 |
> > $(use_enable udev gudev) |
28 |
> > $(use_enable http) |
29 |
> > $(use_enable gnome-keyring keyring) |
30 |
> > $(use_enable samba)" |
31 |
> > } |
32 |
> > |
33 |
> > ugh |
34 |
> > -mike |
35 |
> |
36 |
> Will CC the rest of gnome team because I thought this way of passing |
37 |
> configure options were intentional for some reason (or, at least, I |
38 |
> remember being using it for a looong time) |
39 |
|
40 |
I forgot to CC :S |