Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: Python team <python@g.o>, "Petr Vaněk" <arkamar@×××××.cz>
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment
Date: Mon, 26 Sep 2022 10:07:06
Message-Id: 86cee4684c5d9a47b2823738754c3d562e2279a4.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] distutils-r1.eclass: fix typo in comment by "Petr Vaněk"
1 On Tue, 2022-09-20 at 17:17 +0200, Petr Vaněk wrote:
2 > Signed-off-by: Petr Vaněk <arkamar@×××××.cz>
3 > ---
4 > eclass/distutils-r1.eclass | 4 ++--
5 > 1 file changed, 2 insertions(+), 2 deletions(-)
6 >
7 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
8 > index 60f81473c0a..27bd9207743 100644
9 > --- a/eclass/distutils-r1.eclass
10 > +++ b/eclass/distutils-r1.eclass
11 > @@ -728,8 +728,8 @@ esetup.py() {
12 > # to unmerge the package first.
13 > #
14 > # This function is not available in PEP517 mode. The eclass provides
15 > -# a venv-style install unconditionally therefore, and therefore it
16 > -# should no longer be necessary.
17 > +# a venv-style install unconditionally and therefore it should no longer
18 > +# be necessary.
19 > distutils_install_for_testing() {
20 > debug-print-function ${FUNCNAME} "${@}"
21 >
22
23 Thanks for the patch. While this is definitely good, I'm a bit
24 reluctant to force the big cache regen for this, so I'd rather wait till
25 we have some more changes in queue. I'm a bit afraid I won't remember
26 about it though.
27
28 --
29 Best regards,
30 Michał Górny