Gentoo Archives: gentoo-dev

From: Matt Turner <mattst88@g.o>
To: gentoo-dev@l.g.o
Cc: Matt Turner <mattst88@g.o>
Subject: [gentoo-dev] [PATCH 2/2] xorg-2.eclass: Remove XORG_STATIC
Date: Sat, 09 Jan 2021 04:17:33
Message-Id: 20210109041651.330320-2-mattst88@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Remove XORG_STATIC by Matt Turner
1 Statically linking X libraries into your program is an extremely bad
2 idea.
3
4 Signed-off-by: Matt Turner <mattst88@g.o>
5 ---
6 eclass/xorg-2.eclass | 23 +----------------------
7 1 file changed, 1 insertion(+), 22 deletions(-)
8
9 diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
10 index f3b282e1a11..f9a18b8ec26 100644
11 --- a/eclass/xorg-2.eclass
12 +++ b/eclass/xorg-2.eclass
13 @@ -1,4 +1,4 @@
14 -# Copyright 1999-2020 Gentoo Authors
15 +# Copyright 1999-2021 Gentoo Authors
16 # Distributed under the terms of the GNU General Public License v2
17
18 # @ECLASS: xorg-2.eclass
19 @@ -168,27 +168,6 @@ fi
20 # If we're a driver package, then enable DRIVER case
21 [[ ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] && DRIVER="yes"
22
23 -# @ECLASS-VARIABLE: XORG_STATIC
24 -# @DESCRIPTION:
25 -# Enables static-libs useflag. Set to no, if your package gets:
26 -#
27 -# QA: configure: WARNING: unrecognized options: --disable-static
28 -: ${XORG_STATIC:="yes"}
29 -
30 -# Add static-libs useflag where useful.
31 -if [[ ${XORG_STATIC} == yes \
32 - && ${FONT} != yes \
33 - && ${CATEGORY} != app-doc \
34 - && ${CATEGORY} != x11-apps \
35 - && ${CATEGORY} != x11-drivers \
36 - && ${CATEGORY} != media-fonts \
37 - && ${PN} != util-macros \
38 - && ${PN} != xbitmaps \
39 - && ${PN} != xorg-cf-files \
40 - && ${PN/xcursor} = ${PN} ]]; then
41 - IUSE+=" static-libs"
42 -fi
43 -
44 DEPEND+=" virtual/pkgconfig"
45
46 # @ECLASS-VARIABLE: XORG_DRI
47 --
48 2.26.2

Replies

Subject Author
Re: [gentoo-dev] [PATCH 2/2] xorg-2.eclass: Remove XORG_STATIC David Seifert <soap@g.o>