Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [RFC] New eclass patches.eclass
Date: Tue, 24 Dec 2019 22:02:44
In Reply to: [gentoo-dev] [RFC] New eclass patches.eclass by "Vadim A. Misbakh-Soloviov"
1 On Sun, 2019-12-22 at 16:39 +0700, Vadim A. Misbakh-Soloviov wrote:
2 > HI there!
3 >
4 > Some time ago I invented patches.eclass, which facilitates my work with
5 > patches, and I would like you to express your opinion about it and whether it
6 > is worth committing in gentoo repo.
7 >
8 > Maybe it’s even worth it to become a helper, but not an eclass, or be bundled
9 > somewhere in existing eclasses/helpers.
10 >
12 No. This is just awful implicit magic. While I understand that you
13 believe it makes the work easier for *you* but you are not going to be
14 the only person ever to touch ebuilds you are maintaining today. You
15 are talking of creating a complex directory structure which might or
16 might not affect every ebuild, in hardly predictable ways.
18 Sometimes you won't be able to fit a patch in any of the categories.
19 Then you're going to needlessly duplicate it in multiple directories,
20 triggering CI warnings for duplicate files.
22 Sometimes you will have to jump through hoops to change patching order,
23 so that every subdirectory works correctly.
25 Grepping the ebuilds for applicable files from FILESDIR just won't work.
26 Sure, maybe the proposed structure will be more convenient for cleanup.
27 Unless people accidentally remove whole FILESDIR because they don't see
28 any reference to it.
30 Until this is widely deployed (which is unlikely to happen), people will
31 get very confused over every ebuild using it.
33 Finally, this can only bring real gain if you carry a lot of patches.
34 In that case, I'd really prefer if you put them into a tarball, and into
35 SRC_URI rather than polluting all the Gentoo installations.
37 --
38 Best regards,
39 Michał Górny


File name MIME type
signature.asc application/pgp-signature