| 1 |
On Sunday, January 27, 2013 03:00:21 PM Pacho Ramos wrote: |
| 2 |
> Currently, when people uses DOC_CONTENTS variable to place their desired |
| 3 |
> messages, they are automatically reformatted by "fmt" to get proper |
| 4 |
> messages (for example, splitting long lines). |
| 5 |
> |
| 6 |
> But, in some cases, may be useful to disable this behavior and respect |
| 7 |
> strictly how DOC_CONTENTS was formatted, for example in that kind of |
| 8 |
> messages telling people to run a command and, then, requiring a new line |
| 9 |
> to be used. This can also be useful to append extra information to |
| 10 |
> DOC_CONTENTS when, for example, additional info is needed when enabling |
| 11 |
> a USE flag. |
| 12 |
> |
| 13 |
|
| 14 |
Why does this eclass even exist? Everything that it does can be done directly |
| 15 |
in an ebuild in a couple lines of code, except in a much less ugly manner. It |
| 16 |
doesn't help to generalize anything. If you want to copy a file and call dodoc |
| 17 |
then just do it, don't write a pointless wrapper that people then have to go |
| 18 |
and look up what it does in order to read your ebuilds. The only thing I see |
| 19 |
that's maybe useful is saving on the logic for checking REPLACING_VERSIONS. |
| 20 |
|
| 21 |
You can get rid of all that UUOC / UUOE. The set -f and eshopts stuff is |
| 22 |
unnecessary. You should localize the variables that can be localized like |
| 23 |
ELINE. |
| 24 |
|
| 25 |
Funnily, looking at the implementation of elog, it appears to already mangle |
| 26 |
its input by a pass of `echo -e', pointlessly reading lines and joining them |
| 27 |
back together again repeatedly. This is just horrible! I don't even... |
| 28 |
-- |
| 29 |
Dan Douglas |
Archives