Re: [gentoo-dev] RFC: findlib/ocamlfind eclass

[Matthieu Sozeau]

On Thu, Aug 19, 2004 at 08:36:35PM -0400, Aron Griffis wrote:
> Matthieu Sozeau wrote:	[Thu Aug 19 2004, 03:44:41PM EDT]
> > 	local destdir=`ocamlfind printconf destdir`
> > 	dodir ${destdir}
>
> Shouldn't ocamlfind be checked for failure before running dodir?

ocamlfind should be properly installed if findlib is merged, but you're
right, i could also be broken :)

>
> > 	make DESTDIR=${D} $@ install
>
> You probably want $@ in double-quotes: "$@"  Here is the relevant
> section from the bash man-page:
>
>   @  Expands  to  the positional parameters, starting from one.  When
>      the  expansion  occurs  within  double  quotes,  each  parameter
>      expands to a separate word.  That is, "$@" is equivalent to "$1"
>      "$2" ...  When there are no positional parameters, "$@"  and  $@
>      expand to nothing (i.e., they are removed).

Thanks for the tip!
-- 
BOFH Excuse #6: global warming 
Gentoo Developer (ml, emacs) - http://dev.gentoo.org/~mattam