Gentoo Archives: gentoo-dev

From: Anna Vyalkova <cyber+gentoo@×××××.in>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] verify-sig.eclass: add app-crypt/signify support
Date: Wed, 08 Dec 2021 14:28:35
Message-Id: YbDBCOGWywStP4SM@sysrq.in
In Reply to: Re: [gentoo-dev] [PATCH] verify-sig.eclass: add app-crypt/signify support by "Haelwenn (lanodan) Monnier"
1 On 2021-12-08 13:54, Haelwenn (lanodan) Monnier wrote:
2 > >+case ${VERIFY_SIG_IMPL} in
3 > >+ gnupg)
4 > >+ BDEPEND="
5 > >+ verify-sig? (
6 > >+ app-crypt/gnupg
7 > >+ >=app-portage/gemato-16
8 > >+ )"
9 > >+ ;;
10 > >+ signify)
11 > >+ BDEPEND="verify-sig? ( app-crypt/signify )"
12 >
13 > Might be worth it to depend on app-crypt/minisign instead or depend on any.
14 > minisign is already stabilized and I slightly prefer it's implementation over
15 > the ported signify as there is no vendoring.
16 > That said minisign could be considered bloated compared to signify.
17
18 $ minisign -Vp /usr/share/openpgp-keys/gmid-1.7.pub -m SHA256 -x SHA256.sig -o
19 Trusted signature comment should start with "trusted comment: "
20
21 It doesn't work :/
22 Also it has no "verify signed checksums list" mode.
23
24 > >+ case ${VERIFY_SIG_IMPL} in
25 > >+ gnupg)
26 > >+ gemato gpg-wrap -K "${key}" "${extra_args[@]}" -- \
27 > >+ gpg --verify "${sig}" "${file}" ||
28 > >+ die "PGP signature verification failed"
29 > >+ ;;
30 > >+ signify)
31 > >+ signify -V -p "${key}" -m "${file}" -x "${sig}" ||
32 > >+ die "PGP signature verification failed"
33 >
34 > Should be something like "Signify signature verification failed".
35
36 It's still PGP, so the message is accurate. Having different messages
37 would be inconsistent. That's what I think.