| 1 |
>>>>> On Wed, 18 Jan 2012, Mike Frysinger wrote: |
| 2 |
|
| 3 |
>> CDROM_DISABLE_PROPERTIES=1 |
| 4 |
>> inherit [...] cdrom |
| 5 |
>> |
| 6 |
>> IUSE="cdinstall" |
| 7 |
>> PROPERTIES="cdinstall? ( interactive )" |
| 8 |
>> |
| 9 |
>> It would be required for 7 out of the 36 packages that use cdrom |
| 10 |
>> functions. |
| 11 |
|
| 12 |
> since USE=cdinstall has been our standard, then perhaps we should codify that |
| 13 |
> in the eclass. are there ebuilds that set CDROM_DISABLE_PROPERTIES and don't |
| 14 |
> have IUSE=cdinstall ? |
| 15 |
|
| 16 |
Indeed, all of them have PROPERTIES="cdinstall? ( interactive )". |
| 17 |
|
| 18 |
> ebuild: |
| 19 |
> CDROM_OPTIONAL="yes" |
| 20 |
> inherit cdrom |
| 21 |
|
| 22 |
> eclass: |
| 23 |
> if [[ ${CDROM_OPTIONAL} == "yes" ]] ; then |
| 24 |
> PROPERTIES="cdinstall? ( interactive )" |
| 25 |
> else |
| 26 |
> PROPERTIES="interactive" |
| 27 |
> fi |
| 28 |
> IUSE="cdinstall" |
| 29 |
|
| 30 |
Looks good, except that I would move the IUSE line into the "then" |
| 31 |
clause. |
| 32 |
|
| 33 |
Ulrich |
Archives