Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: hasufell <hasufell@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/)
Date: Sun, 09 Aug 2015 21:11:43
Message-Id: 20150809231123.677e314d@pomiot
In Reply to: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/) by hasufell
1 Dnia 2015-08-09, o godz. 23:01:32
2 hasufell <hasufell@g.o> napisał(a):
3
4 > On 08/09/2015 09:56 PM, Michał Górny wrote:
5 > > Dnia 2015-08-09, o godz. 16:09:29
6 > > hasufell <hasufell@g.o> napisał(a):
7 > >
8 > >> On 08/09/2015 03:58 PM, Michael Weber wrote:
9 > >>> commit: 40b3fd64ec9c5d6d94f0f0897740bc77622c24a1
10 > >>> Author: Michael Weber <xmw <AT> gentoo <DOT> org>
11 > >>> AuthorDate: Sun Aug 9 13:58:26 2015 +0000
12 > >>> Commit: Michael Weber <xmw <AT> gentoo <DOT> org>
13 > >>> CommitDate: Sun Aug 9 13:58:26 2015 +0000
14 > >>> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=40b3fd64
15 > >>>
16 > >>> sci-libs/opencascade: add USE=vtk (bug 557022, thanks Helmut Jarausch).
17 > >>>
18 > >>
19 > >> I was wondering if we should set a standard for referencing bug reports.
20 > >> The portage team already does something like that:
21 > >> https://github.com/gentoo/portage/commit/b7149002bf23889f280c502afe6ceda0b1345ca3
22 > >>
23 > >> Following that, the commit could have been:
24 > >> =====
25 > >> sci-libs/opencascade: add USE=vtk
26 > >>
27 > >> thanks to Helmut Jarausch
28 > >>
29 > >> X-Gentoo-Bug: 557022
30 > >> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=557022
31 > >> =====
32 > >
33 > > Which is terribly redundant. Just put the whole bug URL. Advantages:
34 > >
35 > > - keeps the bug namespaced to bugs.gentoo.org,
36 > > - has the bug no inside,
37 > > - is convenient -- you can click it instead of copy-pasting the no.
38 > >
39 > > Also there are some standard keywords that are sometimes used to
40 > > reference bugs, like 'Fixes:' used by x.org.
41 > >
42 >
43 > I am not sure what exactly you do propose.
44
45 Fixes: https://bugs.gentoo.org/show_bug.cgi?id=557022
46 References: https://bugs.gentoo.org/show_bug.cgi?id=557022
47 X-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=557022
48 Whatever: https://bugs.gentoo.org/show_bug.cgi?id=557022
49
50 Just no magical numbers which are meaningless without the context.
51
52 --
53 Best regards,
54 Michał Górny
55 <http://dev.gentoo.org/~mgorny/>

Replies