| 1 |
On Wednesday 18 January 2012 16:17:50 Michał Górny wrote: |
| 2 |
> On Wed, 18 Jan 2012 15:39:24 -0500 Mike Frysinger wrote: |
| 3 |
> > yes. this func is the primer so it starts at 1, and after this, |
| 4 |
> > |
| 5 |
> > people call cdrom_load_next_cd which then prints out: |
| 6 |
> > einfo "Found CD #2 root at ..." |
| 7 |
> > einfo "Found CD #3 root at ..." |
| 8 |
> > einfo "Found CD #4 root at ..." |
| 9 |
> > |
| 10 |
> > since they have the same `einfo` message structure |
| 11 |
> > |
| 12 |
> > i could replace the variable in the first einfo with a "1", but it |
| 13 |
> > gains nothing, and imo kills the "these messages are clearly in sync |
| 14 |
> > between these two funcs". |
| 15 |
> |
| 16 |
> Then please clearly use the ${!...} magic to get CD_ROOT_1 rather than |
| 17 |
> mixing hardcoded '1' and $CDROM_CURRENT_ID. |
| 18 |
|
| 19 |
pretty sure that's independent of the `einfo` output |
| 20 |
|
| 21 |
i'm probably not going to bother looking for feedback on the code style until |
| 22 |
it gets rewritten in arrays |
| 23 |
-mike |
Archives