Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Please enhance your USE descriptions!
Date: Thu, 31 Mar 2011 07:54:10
Message-Id: 20110331075153.GQ887@gentoo.org
In Reply to: Re: [gentoo-dev] Please enhance your USE descriptions! by "Tomáš Chvátal"
1 On 31-03-2011 09:41:10 +0200, Tomáš Chvátal wrote:
2 > Dne 31.3.2011 09:33, Fabian Groffen napsal(a):
3 > > On 31-03-2011 09:23:16 +0200, justin wrote:
4 > >> instead of the default
5 > >>
6 > >> mp3 - Add support for reading mp3 files
7 > >
8 > > I find the default clear enough. It seems the mp3 USE-flag is
9 > > overloaded with multiple functions, this is likely the cause of the
10 > > problem here.
11 > >
12 > The mp3 useflag is correct. It just can use mpg123 which is actualy
13 > better implementation and if you compile mplayer with -mp3 then it looks
14 > to libavcodec for the mp3 support (which is supposed to be worse than
15 > the mpg123).
16
17 use.desc gives the default USE-description, which says it enables
18 support for reading mp3 files. Hence, (based on what you say) the
19 useflag is incorrect for mplayer, because it can *always* read
20 mp3-files.
21
22 mplayer should not use mp3 USE-flag, because -mp3 to still have a
23 mp3-reading capable player feels quite counter-intuitive. It happens to
24 be that mp3 USE-flag is hooked up to the encode USE-flag -- this is
25 where it no longer has anything to do with the description from
26 use.desc.
27
28
29 --
30 Fabian Groffen
31 Gentoo on a different level

Replies

Subject Author
Re: [gentoo-dev] Please enhance your USE descriptions! "Tomáš Chvátal" <scarabeus@g.o>