Pass "${@}" in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils.

[Michael Weber]

Hi,

I'm not sure if it's a sane way to push make -j1 via

src_compile() {
    cmake-multilib_src_compile -j1
}

but I detected a lack of functionality in the current
cmake-multilib.eclass. Both cmake-utils.eclass and multilib-build.eclass
have it, so it might be sound to continue with this behavior.

Comments, pls.

   Michael


Index: cmake-multilib.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/cmake-multilib.eclass,v
retrieving revision 1.1
diff -u -B -r1.1 cmake-multilib.eclass
--- cmake-multilib.eclass       10 Feb 2013 11:44:55 -0000      1.1
+++ cmake-multilib.eclass       13 Apr 2013 00:58:17 -0000
@@ -33,24 +33,24 @@
 EXPORT_FUNCTIONS src_configure src_compile src_test src_install

 cmake-multilib_src_configure() {
-       multilib_parallel_foreach_abi cmake-utils_src_configure
+       multilib_parallel_foreach_abi cmake-utils_src_configure "${@}"
 }

 cmake-multilib_src_compile() {
-       multilib_foreach_abi cmake-utils_src_compile
+       multilib_foreach_abi cmake-utils_src_compile "${@}"
 }

 cmake-multilib_src_test() {
-       multilib_foreach_abi cmake-utils_src_test
+       multilib_foreach_abi cmake-utils_src_test "${@}"
 }

 cmake-multilib_src_install() {
        cmake-multilib_secure_install() {
-               cmake-utils_src_install
+               cmake-utils_src_install "${@}"

                # Make sure all headers are the same for each ABI.
                multilib_check_headers
        }

-       multilib_foreach_abi cmake-multilib_secure_install
+       multilib_foreach_abi cmake-multilib_secure_install "${@}"
 }


-- 
Michael Weber
Gentoo Developer
web: https://xmw.de/
mailto: Michael Weber <xmw@g.o>