Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-dev@l.g.o
Cc: ruby@g.o, Mike Gilbert <floppym@g.o>
Subject: [gentoo-dev] [PATCH] ruby-ng.eclass: replace ebegin with einfo in _ruby_invoke_environment
Date: Sun, 03 Jul 2022 19:45:37
Message-Id: 20220703194520.1235367-1-floppym@gentoo.org
1 Calling ebegin here makes no sense because it is likely that the called
2 function will also generate output. This will lead to the "[ ok ]"
3 potentially appearing many lines later.
4
5 It also leads to nested ebegin calls, which make no sense for the same
6 reason.
7
8 Closes: https://bugs.gentoo.org/839585
9 Closes: https://bugs.gentoo.org/839588
10 Signed-off-by: Mike Gilbert <floppym@g.o>
11 ---
12 eclass/ruby-ng.eclass | 3 +--
13 1 file changed, 1 insertion(+), 2 deletions(-)
14
15 diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
16 index f0d6c4f6f6c..c43d5b4d982 100644
17 --- a/eclass/ruby-ng.eclass
18 +++ b/eclass/ruby-ng.eclass
19 @@ -410,9 +410,8 @@ _ruby_invoke_environment() {
20 pushd "${WORKDIR}" &>/dev/null || die
21 fi
22
23 - ebegin "Running ${_PHASE:-${EBUILD_PHASE}} phase for $environment"
24 + einfo "Running ${_PHASE:-${EBUILD_PHASE}} phase for $environment"
25 "$@"
26 - eend $?
27 popd &>/dev/null || die
28
29 S=${old_S}
30 --
31 2.36.1

Replies