| 1 |
-----BEGIN PGP SIGNED MESSAGE-----
|
| 2 |
Hash: SHA256
|
| 3 |
|
| 4 |
On Tue, 30 Jul 2019 23:26:27 +0100
|
| 5 |
James Le Cuirot <chewi@g.o> wrote:
|
| 6 |
|
| 7 |
> > Admittedly without a full understanding of the problem, but this |
| 8 |
> > looks wrong to me: SYSROOT, EPREFIX and BROOT are only relevant in |
| 9 |
> > build phases (src_*); (EPREFIX is a little special here but mostly |
| 10 |
> > for convenience). ROOT is only relevant in pkg_* phases. I don't |
| 11 |
> > see how this can work. Say I build a binpkg with ROOT=/ then use |
| 12 |
> > that binpkg with ROOT=/somewhere, you can't go back and change |
| 13 |
> > SYSROOT. |
| 14 |
> |
| 15 |
> ROOT is used to determine ESYSROOT, not the other way around. As you |
| 16 |
> say, (E)SYSROOT is only relevant in src phases so it doesn't matter if |
| 17 |
> ROOT has changed when installing a binpkg. |
| 18 |
|
| 19 |
I am missing something here: You are making ESYSROOT depend on the
|
| 20 |
value of ROOT, so how can it not matter ?
|
| 21 |
|
| 22 |
> I take your point that setting a src phase variable based on a pkg |
| 23 |
> phase variable seems odd but we're only using ROOT to determine the |
| 24 |
> applicable prefix. We're not taking the actual value of ROOT. When |
| 25 |
> Portage works all this out, it has access to all the necessary |
| 26 |
> variables. It only filters the variables based on the phase function |
| 27 |
> later on. |
| 28 |
|
| 29 |
The value does not really matter, the dependency of a variable used in
|
| 30 |
src_* from a variable that can change when installing a binpkg is what
|
| 31 |
worries me here.
|
| 32 |
|
| 33 |
|
| 34 |
Alexis.
|
| 35 |
-----BEGIN PGP SIGNATURE-----
|
| 36 |
|
| 37 |
iHUEAREIAB0WIQSpOxaxaZikKNVNlsYOJUi7xgflrgUCXUGc/gAKCRAOJUi7xgfl
|
| 38 |
rrlNAP9AEX0enc5Tzh++N6I+P4ZKp0hBdljlYBteYTuEipZLEAD/a3fT/pgOR3HJ
|
| 39 |
LyGvu98wHn6sCldtBMjoV/RgrxfaKO8=
|
| 40 |
=L9Hp
|
| 41 |
-----END PGP SIGNATURE----- |
Archives