Gentoo Archives: gentoo-dev

From: Ryan Hill <rhill@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [PATCH v1] enable gccgo for all platform
Date: Sun, 15 Nov 2015 08:30:45
Message-Id: 20151115023441.3ce747ee@caribou.gateway.pace.com
In Reply to: [gentoo-dev] [PATCH v1] enable gccgo for all platform by Leno Hou
1 On Mon, 2 Nov 2015 12:17:26 -0500
2 Leno Hou <lenohou@×××××.com> wrote:
3
4 > 1. go compiler only support x86 platform
5 > 2. gcc 5 includes go command to build go apps
6 > 3. for coreos enablement, it's use gcc 5 to build go apps
7
8 > diff --git a/app-admin/consul-template/consul-template-0.9.0-r1.ebuild
9 > b/app-admin/consul-template/consul-template-0.9.0-r1.ebuild index
10 > cbc1059..a24ec80 100644 ---
11 > a/app-admin/consul-template/consul-template-0.9.0-r1.ebuild +++
12 > b/app-admin/consul-template/consul-template-0.9.0-r1.ebuild @@ -14,7 +14,10
13 > @@ LICENSE="MPL-2.0" SLOT="0"
14 > IUSE="test"
15 >
16 > -DEPEND=">=dev-lang/go-1.4:=
17 > +DEPEND="|| (
18 > + >=dev-lang/go-1.4:=
19 > + >=sys-devel/gcc-5.1.0:=[go]
20 > + )
21 > test? ( dev-go/go-tools )
22 > app-admin/consul
23 > app-admin/vault"
24
25 You cannot simply have a dependency on gcc like this. Just because there is a
26 compiler installed that satisfies the dependency doesn't mean that compiler is
27 the one currently being used. I could have gcc 5 with go support installed
28 while using gcc 6 without go. You need to either do a compile test or query
29 the compiler in some way to ensure the needed support is there. Look at the
30 fortran virtual and fortran-2 eclass for an example.
31
32
33 --
34 Ryan Hill psn: dirtyepic_sk
35 gcc-porting/toolchain/wxwidgets @ gentoo.org
36
37 47C3 6D62 4864 0E49 8E9E 7F92 ED38 BD49 957A 8463