1 |
On 06/15/12 09:32, Michał Górny wrote: |
2 |
> It is a little confusing when the function reports .a removal when no |
3 |
> such file exists. Also, explain why the file is removed. |
4 |
|
5 |
Why keep the "-f"? |
6 |
|
7 |
|
8 |
> --- |
9 |
> eclass/eutils.eclass | 6 ++++-- |
10 |
> 1 file changed, 4 insertions(+), 2 deletions(-) |
11 |
> |
12 |
> diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass |
13 |
> index 116f7bc..931d97d 100644 |
14 |
> --- a/eclass/eutils.eclass |
15 |
> +++ b/eclass/eutils.eclass |
16 |
> @@ -1438,8 +1438,10 @@ prune_libtool_files() { |
17 |
> |
18 |
> # Remove static libs we're not supposed to link against. |
19 |
> if grep -q '^shouldnotlink=yes$' "${f}"; then |
20 |
> - einfo "Removing unnecessary ${archivefile#${D%/}}" |
21 |
> - rm -f "${archivefile}" |
22 |
> + if [[ -f ${archivefile} ]]; then |
23 |
> + einfo "Removing unnecessary ${archivefile#${D%/}} (static plugin)" |
24 |
> + rm -f "${archivefile}" |
25 |
> + fi |
26 |
> |
27 |
> # The .la file may be used by a module loader, so avoid removing it |
28 |
> # unless explicitly requested. |