Re: [gentoo-dev] git-2.eclass final review

[Mike Frysinger]

> # @BLURB: This eclass provides functions for fetch and unpack git repositories

fetching/unpacking

>	eval X="\$${PN//[-+]/_}_LIVE_REPO"
>	if [[ ${X} = "" ]]; then
>		: ${EGIT_REPO_URI:=}
>	else
>		EGIT_REPO_URI="${X}"
>	fi

X needs to be marked local, and could be condensed:
EGIT_REPO_URI=${X:-${EGIT_REPO_URI}}

the PN_LIVE_REPO override documentation is missing

same feedback for all the vars after this too

> 	git-2_fetch $@

missing quotes
-mike