Re: [gentoo-dev] init.d-scripts don't see stuff from /etc/profile.env

[Mike Frysinger]

On Tuesday 30 August 2005 05:32 pm, Roy Marples wrote:
> On Thu, 2005-08-25 at 12:01 +0200, Paul de Vrieze wrote:
> > On Wednesday 24 August 2005 12:04, Roy Marples wrote:
> > > Um, that's kinda like behaviour by design unless anyone can tell me
> > > otherwise.
> > >
> > > /etc/env.d/* just set shell variables, so if you change one then you
> > > need to
> > >
> > > env-update
> > > source /etc/profile
> > > /etc/init.d/thisdaemon restart
> > >
> > > To refresh the daemon that needs the vars
> >
> > Perhaps the init script loader should be changed such that the
> > environment variables from the shell calling the script are ignored, and
> > an
> > environment equal to that when being called by init is used.
>
> I've been looking into this and the only easy solution I can find is to
> move /sbin/runscript.sh to say /lib/rcscripts/sh, change it to
> source /etc/profile and then create a new /sbin/runscript.sh like so
>
> Right away we can see that we actually do need some to keep some env
> vars and the list would be constantly updated. There's also nothing to
> stop the user from setting them and then running a script which kind of
> defeats the purpose here anyway.
>
> Personally I'm against this.I'd like to know what Azarah and Vapier
> think of this though. Others too!

init.d scripts should have a pure env given to them ... which means, they 
should be run with `env -i` and have only whitelisted variables given to them 
(and everything that appears in /etc/conf.d/$service /etc/conf.d/rc 
and /etc/rc.conf) ...

after all, you wouldnt want something like apache having all those vars in its 
env because they'd show up in php script env which means available to the 
public
-mike
-- 
gentoo-dev@g.o mailing list