Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Don't require assignment of empty variables in ebuilds?
Date: Wed, 25 Jul 2012 18:33:16
Message-Id: 201207251432.19238.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] Don't require assignment of empty variables in ebuilds? by Ulrich Mueller
1 On Wednesday 25 July 2012 12:38:05 Ulrich Mueller wrote:
2 > >>>>> On Wed, 25 Jul 2012, Mike Frysinger wrote:
3 > >> Our current policy [1] requires that ebuilds must assign the seven
4 > >> variables DESCRIPTION, HOMEPAGE, SRC_URI, LICENSE, SLOT, KEYWORDS,
5 > >> and IUSE, even if their value is empty.
6 > >>
7 > >> Could we drop this requirement? Repoman already enforces that
8 > >> DESCRIPTION, HOMEPAGE, LICENSE, SLOT, and KEYWORDS are non-empty
9 > >> (with some exceptions for virtuals). I don't see why we need to
10 > >> distinguish the "empty value" and "not assigned" cases.
11 > >
12 > > i think we should clarify and say that when an eclass provides
13 > > these, the ebuild need not. completely missing DESCRIPTION/HOMEPAGE
14 > > should be a warning (and maybe KEYWORDS), and LICENSE should be an
15 > > error. there are plenty of examples of SRC_URI not being set and
16 > > that's fine (live ebuilds, ebuilds that only install out of
17 > > $FILESDIR, virtuals, etc...).
18 >
19 > I think we have to distinguish between PMS and tree policy here.
20
21 who said anything about PMS ? ;) this thread was all about tree policy.
22
23 > The package manager should be able to handle any empty or missing
24 > variables (except for DESCRIPTION and SLOT). Otherwise we'd have to
25 > complicate the spec with additional case distinctions, e.g. for
26 > virtuals.
27
28 SLOT is about the only variable i could see possibly being required by PMS to
29 be set somewhere (whether eclass or ebuild doesn't matter). all the others we
30 could (and should) do away with from PMS requirement list considering our PMs
31 handle it fine.
32 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature