Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Matt Turner <mattst88@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Fix font IUSE=nls handling
Date: Thu, 01 Oct 2020 08:07:10
Message-Id: ueemiqsip@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/2] xorg-3.eclass: Fix font IUSE=nls handling by Matt Turner
1 >>>>> On Thu, 01 Oct 2020, Matt Turner wrote:
2
3 > - [[ ${PN} = font-misc-misc || ${PN} = font-schumacher-misc || ${PN##*-} = 75dpi || ${PN##*-} = 100dpi || ${PN##*-} = cyrillic ]] && IUSE+=" nls"
4 > + case ${PN#font-} in
5 > + adobe-100dpi|adobe-utopia-100dpi|bh-100dpi|bh-lucidatypewriter-100dpi|\
6 > + adobe-75dpi |adobe-utopia-75dpi |bh-75dpi |bh-lucidatypewriter-75dpi|\
7 > + misc-misc|schumacher-misc)
8 > + IUSE+=" nls"
9 > + ;;
10 > + esac
11
12 This looks like the kind of logic that would better be moved to ebuilds.
13 Especially when it has just proven to be error prone.
14
15 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies