Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: ml@g.o, "Maciej Barć" <xgqt@g.o>
Subject: Re: [gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes
Date: Thu, 09 Dec 2021 22:29:37
Message-Id: D5AB71DB-C948-4689-81D9-67C5E42DC27F@gentoo.org
In Reply to: [gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes by "Maciej Barć"
1 > On 9 Dec 2021, at 22:10, Maciej Barć <xgqt@g.o> wrote:
2 >
3 > bump to EAPI 8
4
5 Say "support EAPI 8" instead.
6
7 May be worth splitting the commit into a few different changes
8 so the summary can be more informative than "fixes"
9 (try git add -p).
10
11 lgtm otherwise, thanks for doing this!
12
13 > drop support for EAPI 5
14 > set DUNE_PKG_NAME to PN by default
15 > move "Move docs to the appropriate place" block to dune-install
16 > to make dune-install now handle a list of subpackages correctly
17 >
18 > Signed-off-by: Maciej Barć <xgqt@g.o>
19 > ---
20 > eclass/dune.eclass | 50 ++++++++++++++++++++++++++++------------------
21 > 1 file changed, 31 insertions(+), 19 deletions(-)
22 > [snip]
23
24 Best,
25 sam

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] [PATCH v2] eclass/dune.eclass: fixes "Maciej Barć" <xgqt@g.o>