Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: avoid nested ebegin calls
Date: Mon, 11 Jul 2022 11:37:03
Message-Id: CAJ0EP420AiDQHB=8fNVjPvMehQdbDZmCT-LmhVRpiX72=KOrgA@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] python-utils-r1.eclass: avoid nested ebegin calls by "Michał Górny"
1 On Mon, Jul 11, 2022 at 3:04 AM Michał Górny <mgorny@g.o> wrote:
2 >
3 > On Sun, 2022-07-10 at 23:53 -0400, Mike Gilbert wrote:
4 > > It's common for python_check_deps to call python_has_version, which
5 > > calls ebegin itself.
6 > >
7 > > Signed-off-by: Mike Gilbert <floppym@g.o>
8 > > ---
9 > > eclass/python-utils-r1.eclass | 3 +--
10 > > 1 file changed, 1 insertion(+), 2 deletions(-)
11 > >
12 > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
13 > > index a18ca58475f..acfa83d5e18 100644
14 > > --- a/eclass/python-utils-r1.eclass
15 > > +++ b/eclass/python-utils-r1.eclass
16 > > @@ -1399,9 +1399,8 @@ _python_run_check_deps() {
17 > >
18 > > local PYTHON_USEDEP="python_targets_${impl}(-)"
19 > > local PYTHON_SINGLE_USEDEP="python_single_target_${impl}(-)"
20 > > - ebegin " python_check_deps"
21 > > + einfo " python_check_deps"
22 > > python_check_deps
23 > > - eend ${?}
24 > > }
25 > >
26 > > # @FUNCTION: python_has_version
27 >
28 > What's the harm in nesting them?
29
30 It results in strange looking output, and triggers a QA warning in the
31 latest version of Portage.

Replies