Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: williamh@g.o, chewi@g.o, Mike Gilbert <floppym@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/3] meson.eclass: use python eselect module in _meson_env_array
Date: Thu, 17 Dec 2020 21:44:20
Message-Id: 650b003aa06d3062438f25e94ab6f45108f2147d.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/3] meson.eclass: use python eselect module in _meson_env_array by Mike Gilbert
1 On Thu, 2020-12-17 at 16:30 -0500, Mike Gilbert wrote:
2 > Closes: https://bugs.gentoo.org/759433
3 > Signed-off-by: Mike Gilbert <floppym@g.o>
4 > ---
5 >  eclass/meson.eclass | 3 ++-
6 >  1 file changed, 2 insertions(+), 1 deletion(-)
7 >
8 > diff --git a/eclass/meson.eclass b/eclass/meson.eclass
9 > index 21338280df33..6296f1dd26e5 100644
10 > --- a/eclass/meson.eclass
11 > +++ b/eclass/meson.eclass
12 > @@ -126,7 +126,8 @@ EOF
13 >  #          '--unicode-16=𐐷', '--unicode-32=𐤅']
14 >  #
15 >  _meson_env_array() {
16 > -       python -c "${__MESON_ARRAY_PARSER}" "$@"
17 > +       local python="$(eselect python show)"
18 > +       ${python} -c "${__MESON_ARRAY_PARSER}" "$@"
19 >  }
20 >  
21 >  # @FUNCTION: _meson_get_machine_info
22
23 You're missing a BDEPEND on app-eselect/eselect-python.
24
25 Also, I really don't like these workarounds. It takes a lot of effort
26 to figure out how to break stuff, so people stop doing awful things.
27 It's disrespectful to my time when you invent new hacks. Now I'll have
28 to figure out how to change eselect-python to break it.
29
30 --
31 Best regards,
32 Michał Górny

Replies