1 |
On 7/4/22 16:19, Florian Schmaus wrote: |
2 |
> I'd like to propose a new metadata XML element for packages: |
3 |
> |
4 |
> <non-maintainer-commits-welcome/> |
5 |
> |
6 |
> Maintainers can signal to other developers (and of course contributors |
7 |
> in general) that they are happy with others to make changes to the |
8 |
> ebuilds without prior consultation of the maintainer. |
9 |
> |
10 |
> Of course, this is not a free ticket to always make changes to packages |
11 |
> that you do not maintain without prior consultation of the maintainer. I |
12 |
> would expect people to use their common sense to decide if a change may |
13 |
> require maintainer attention or not. In general, it is always a good |
14 |
> idea to communicate changes in every case. |
15 |
> |
16 |
> The absence of the flag does not automatically allow the conclusion that |
17 |
> the maintainer is opposed to non-maintainer commits. It just means that |
18 |
> the maintainer's stance is not known. I do not believe that we need a |
19 |
> <non-maintainer-commits-disallowed/> flag, but if the need arises, we |
20 |
> could always consider adding one. Although, in my experience, people |
21 |
> mostly like to communicate the "non-maintainer commits welcome" policy |
22 |
> with others. |
23 |
|
24 |
I worry that this might send wrong signal. My understanding is that just |
25 |
like any OSS also Gentoo struggles with attracting new contributors and |
26 |
telling anybody "hey, your contribution is not welcome" does not help. |
27 |
|
28 |
I think that rejecting a contribution (regardless of the flag) should be |
29 |
based on technical merit, rather than individual maintainers personal |
30 |
preferences. I do understand some packages are like your babies, you |
31 |
watch them grow, fine tune everything. But in the end, if somebody finds |
32 |
a bug in the ebuild/eclass/... and is even willing to provide a fix, we |
33 |
should have a discussion about the proposed fix rather than refer to a |
34 |
flag (or lack of thereof) when closing the MR (unmerged). |
35 |
|
36 |
Michal |