Re: [gentoo-dev] mercurial.eclass: change clone destination

[Petteri Räty]

On 11/08/2010 06:17 AM, Donnie Berkholz wrote:
> On 16:42 Sun 07 Nov     , Petteri Räty wrote:
>> On 11/06/2010 11:22 AM, Krzysztof Pawlik wrote:
>>> Hello,
>>>
>>> I'm sending this patch for discussion, what it changes? The change is to where
>>> the final clone of repository will be placed, it used to be ${WORKDIR}/${module}
>>> (where module usually is the last component of source URI) to ${WORKDIR}/${P}
>>> (essentially ${S}). This has few effects:
>>>  - ebuilds using mercurial.eclass don't need to set S any longer
>>>  - mercurial.eclass behaves more like git.eclass
>>>  - it breaks all existing ebuilds using this eclass
>>
>> Which means that the doing the chance is not allowed as eclasses must
>> remain backwards compatible.
>
> Is that really still the case now that full environments have been saved
> for a number of years? Clearly breaking things is unacceptable, but I
> could envision someone simultaneously updating the eclass and all
> consumers.
>

There's no full environment saved before the package is installed and I
don't see why we should break overlays.

Regards,
Petteri