Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: toolchain@g.o, "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 1/4] toolchain-funcs.eclass: Fix _tc-getPROG with multi-parameter defaults
Date: Wed, 22 Jun 2016 20:07:49
Message-Id: 20160622200654.6961-2-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/4] toolchain-funcs.eclass: fix for version checks (v2) + compiler identification by "Michał Górny"
1 Fix _tc-getPROG function to account correctly for default values that
2 contain program name along with arguments, e.g. the default for CPP
3 containing "$(CC) -E".
4 ---
5 eclass/toolchain-funcs.eclass | 6 +++---
6 1 file changed, 3 insertions(+), 3 deletions(-)
7
8 diff --git a/eclass/toolchain-funcs.eclass b/eclass/toolchain-funcs.eclass
9 index e794559..7119a46 100644
10 --- a/eclass/toolchain-funcs.eclass
11 +++ b/eclass/toolchain-funcs.eclass
12 @@ -34,11 +34,11 @@ _tc-getPROG() {
13 done
14
15 local search=
16 - [[ -n $4 ]] && search=$(type -p "$4-${prog}")
17 - [[ -z ${search} && -n ${!tuple} ]] && search=$(type -p "${!tuple}-${prog}")
18 + [[ -n $4 ]] && search=$(type -p $4-${prog})
19 + [[ -z ${search} && -n ${!tuple} ]] && search=$(type -p ${!tuple}-${prog})
20 [[ -n ${search} ]] && prog=${search##*/}
21
22 - export ${var}=${prog}
23 + export ${var}="${prog}"
24 echo "${!var}"
25 }
26 tc-getBUILD_PROG() { _tc-getPROG CBUILD "BUILD_$1 $1_FOR_BUILD HOST$1" "${@:2}"; }
27 --
28 2.9.0

Replies