From: | "Toralf Förster" <toralf@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Subject: | Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests | ||
Date: | Wed, 27 May 2020 12:45:41 | ||
Message-Id: | 9de5a6f6-340d-e039-4bb9-0c47a0480355@gentoo.org | ||
In Reply to: | RE: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests by Thomas Deutschmann |
1 | On 5/27/20 2:16 PM, Thomas Deutschmann wrote: |
2 | > The problem when doing review on Github |
3 | > for me is, that we usually create new revisions. Therefore we don't see |
4 | > what's changed in new revision versus previous revision. |
5 | That's my main concern with the current behaviour: a "git diff" often doesn't show a diff against the previous (ebuild) file, it shows a diff against /dev/null :-/ |
6 | |
7 | -- |
8 | Toralf |
9 | PGP 23217DA7 9B888F45 |
File name | MIME type |
---|---|
signature.asc | application/pgp-signature |
Subject | Author |
---|---|
Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests | Guilherme Amadio <amadio@g.o> |