[gentoo-dev] Re: [PATCH v3 1/1] edo.eclass: add new eclass

[Ulrich Mueller]

>>>>> On Sun, 17 Apr 2022, Sam James wrote:

> --- /dev/null
> +++ b/eclass/edo.eclass
> @@ -0,0 +1,45 @@
> +# Copyright 2022 Gentoo Authors
> +# Distributed under the terms of the GNU General Public License v2
> +
> +# @ECLASS: edo.class
> +# @MAINTAINER:
> +# QA Team <qa@g.o>
> +# @AUTHOR:
> +# Sam James <sam@g.o>
> +# @SUPPORTED_EAPIS: 7 8
> +# @BLURB: Convenience function to run commands verbosely and die on failure
> +# @DESCRIPTION:
> +# This eclass provides the 'edo' command, and an 'edob' variant for ebegin/eend,
> +# which dies (exits) on failure and logs the command used verbosely.
> +#
> +
> +case ${EAPI:-0} in

Just ${EAPI} here, the fallback isn't necessary.

> +	7|8) ;;
> +	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> +esac
> +
> +if [[ -z ${_EDO_ECLASS} ]] ; then
> +_EDO_ECLASS=1
> +
> +# @FUNCTION: edo
> +# @USAGE: <command> [<args>...]
> +# @DESCRIPTION:
> +# Executes a short 'command' with any given arguments and exits on failure unless

Long line.

> +# called under 'nonfatal'.
> +edo() {
> +	einfo "$@"
> +	"$@" || die -n "Failed to run command: $@"
> +}
> +
> +# @FUNCTION: edob
> +# @USAGE: <command> [<args>...]
> +# @DESCRIPTION:
> +# Executes 'command' with ebegin & eend with any given arguments and exits
> +# on failure unless called under 'nonfatal'.
> +edob() {
> +	ebegin "Running $@"
> +	"$@"
> +	eend $? || die -n "Failed to run command: $@"
> +}
> +
> +fi