Gentoo Archives: gentoo-dev

From: Michael Palimaka <kensington@g.o>
To: gentoo-dev@l.g.o
Cc: Michael Palimaka <kensington@g.o>
Subject: [gentoo-dev] [PATCH 08/15] cmake-utils.eclass: namespace some private functions
Date: Wed, 20 Jan 2016 10:49:07
Message-Id: 1453286593-26823-9-git-send-email-kensington@gentoo.org
In Reply to: [gentoo-dev] [PATCH 00/15] EAPI 6 support for cmake-utils.eclas by Michael Palimaka
1 ---
2 eclass/cmake-utils.eclass | 66 +++++++++++++++++++++++------------------------
3 1 file changed, 33 insertions(+), 33 deletions(-)
4
5 diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
6 index e8b24bd..df33fd9 100644
7 --- a/eclass/cmake-utils.eclass
8 +++ b/eclass/cmake-utils.eclass
9 @@ -158,7 +158,7 @@ DEPEND="${CMAKEDEPEND}"
10 unset CMAKEDEPEND
11
12 # Internal functions used by cmake-utils_use_*
13 -_use_me_now() {
14 +_cmake_use_me_now() {
15 debug-print-function ${FUNCNAME} "$@"
16
17 local uper capitalised x
18 @@ -175,7 +175,7 @@ _use_me_now() {
19 done
20 fi
21 }
22 -_use_me_now_inverted() {
23 +_cmake_use_me_now_inverted() {
24 debug-print-function ${FUNCNAME} "$@"
25
26 local uper capitalised x
27 @@ -194,7 +194,7 @@ _use_me_now_inverted() {
28 }
29
30 # Determine using IN or OUT source build
31 -_check_build_dir() {
32 +_cmake_check_build_dir() {
33 : ${CMAKE_USE_DIR:=${S}}
34 if [[ -n ${CMAKE_IN_SOURCE_BUILD} ]]; then
35 # we build in source dir
36 @@ -226,7 +226,7 @@ _check_build_dir() {
37 }
38
39 # Determine which generator to use
40 -_generator_to_use() {
41 +_cmake_generator_to_use() {
42 local generator_name
43
44 case ${CMAKE_MAKEFILE_GENERATOR} in
45 @@ -283,7 +283,7 @@ comment_add_subdirectory() {
46 #
47 # `cmake-utils_use_with foo FOO` echoes -DWITH_FOO=ON if foo is enabled
48 # and -DWITH_FOO=OFF if it is disabled.
49 -cmake-utils_use_with() { _use_me_now WITH_ "$@" ; }
50 +cmake-utils_use_with() { _cmake_use_me_now WITH_ "$@" ; }
51
52 # @FUNCTION: cmake-utils_use_enable
53 # @USAGE: <USE flag> [flag name]
54 @@ -292,7 +292,7 @@ cmake-utils_use_with() { _use_me_now WITH_ "$@" ; }
55 #
56 # `cmake-utils_use_enable foo FOO` echoes -DENABLE_FOO=ON if foo is enabled
57 # and -DENABLE_FOO=OFF if it is disabled.
58 -cmake-utils_use_enable() { _use_me_now ENABLE_ "$@" ; }
59 +cmake-utils_use_enable() { _cmake_use_me_now ENABLE_ "$@" ; }
60
61 # @FUNCTION: cmake-utils_use_find_package
62 # @USAGE: <USE flag> [flag name]
63 @@ -302,7 +302,7 @@ cmake-utils_use_enable() { _use_me_now ENABLE_ "$@" ; }
64 # `cmake-utils_use_find_package foo LibFoo` echoes -DCMAKE_DISABLE_FIND_PACKAGE_LibFoo=OFF
65 # if foo is enabled and -DCMAKE_DISABLE_FIND_PACKAGE_LibFoo=ON if it is disabled.
66 # This can be used to make find_package optional.
67 -cmake-utils_use_find_package() { _use_me_now_inverted CMAKE_DISABLE_FIND_PACKAGE_ "$@" ; }
68 +cmake-utils_use_find_package() { _cmake_use_me_now_inverted CMAKE_DISABLE_FIND_PACKAGE_ "$@" ; }
69
70 # @FUNCTION: cmake-utils_use_disable
71 # @USAGE: <USE flag> [flag name]
72 @@ -311,7 +311,7 @@ cmake-utils_use_find_package() { _use_me_now_inverted CMAKE_DISABLE_FIND_PACKAGE
73 #
74 # `cmake-utils_use_enable foo FOO` echoes -DDISABLE_FOO=OFF if foo is enabled
75 # and -DDISABLE_FOO=ON if it is disabled.
76 -cmake-utils_use_disable() { _use_me_now_inverted DISABLE_ "$@" ; }
77 +cmake-utils_use_disable() { _cmake_use_me_now_inverted DISABLE_ "$@" ; }
78
79 # @FUNCTION: cmake-utils_use_no
80 # @USAGE: <USE flag> [flag name]
81 @@ -320,7 +320,7 @@ cmake-utils_use_disable() { _use_me_now_inverted DISABLE_ "$@" ; }
82 #
83 # `cmake-utils_use_no foo FOO` echoes -DNO_FOO=OFF if foo is enabled
84 # and -DNO_FOO=ON if it is disabled.
85 -cmake-utils_use_no() { _use_me_now_inverted NO_ "$@" ; }
86 +cmake-utils_use_no() { _cmake_use_me_now_inverted NO_ "$@" ; }
87
88 # @FUNCTION: cmake-utils_use_want
89 # @USAGE: <USE flag> [flag name]
90 @@ -329,7 +329,7 @@ cmake-utils_use_no() { _use_me_now_inverted NO_ "$@" ; }
91 #
92 # `cmake-utils_use_want foo FOO` echoes -DWANT_FOO=ON if foo is enabled
93 # and -DWANT_FOO=OFF if it is disabled.
94 -cmake-utils_use_want() { _use_me_now WANT_ "$@" ; }
95 +cmake-utils_use_want() { _cmake_use_me_now WANT_ "$@" ; }
96
97 # @FUNCTION: cmake-utils_use_build
98 # @USAGE: <USE flag> [flag name]
99 @@ -338,7 +338,7 @@ cmake-utils_use_want() { _use_me_now WANT_ "$@" ; }
100 #
101 # `cmake-utils_use_build foo FOO` echoes -DBUILD_FOO=ON if foo is enabled
102 # and -DBUILD_FOO=OFF if it is disabled.
103 -cmake-utils_use_build() { _use_me_now BUILD_ "$@" ; }
104 +cmake-utils_use_build() { _cmake_use_me_now BUILD_ "$@" ; }
105
106 # @FUNCTION: cmake-utils_use_has
107 # @USAGE: <USE flag> [flag name]
108 @@ -347,7 +347,7 @@ cmake-utils_use_build() { _use_me_now BUILD_ "$@" ; }
109 #
110 # `cmake-utils_use_has foo FOO` echoes -DHAVE_FOO=ON if foo is enabled
111 # and -DHAVE_FOO=OFF if it is disabled.
112 -cmake-utils_use_has() { _use_me_now HAVE_ "$@" ; }
113 +cmake-utils_use_has() { _cmake_use_me_now HAVE_ "$@" ; }
114
115 # @FUNCTION: cmake-utils_use_use
116 # @USAGE: <USE flag> [flag name]
117 @@ -356,7 +356,7 @@ cmake-utils_use_has() { _use_me_now HAVE_ "$@" ; }
118 #
119 # `cmake-utils_use_use foo FOO` echoes -DUSE_FOO=ON if foo is enabled
120 # and -DUSE_FOO=OFF if it is disabled.
121 -cmake-utils_use_use() { _use_me_now USE_ "$@" ; }
122 +cmake-utils_use_use() { _cmake_use_me_now USE_ "$@" ; }
123
124 # @FUNCTION: cmake-utils_use
125 # @USAGE: <USE flag> [flag name]
126 @@ -365,7 +365,7 @@ cmake-utils_use_use() { _use_me_now USE_ "$@" ; }
127 #
128 # `cmake-utils_use foo FOO` echoes -DFOO=ON if foo is enabled
129 # and -DFOO=OFF if it is disabled.
130 -cmake-utils_use() { _use_me_now "" "$@" ; }
131 +cmake-utils_use() { _cmake_use_me_now "" "$@" ; }
132
133 # @FUNCTION: cmake-utils_useno
134 # @USAGE: <USE flag> [flag name]
135 @@ -374,11 +374,11 @@ cmake-utils_use() { _use_me_now "" "$@" ; }
136 #
137 # `cmake-utils_useno foo NOFOO` echoes -DNOFOO=OFF if foo is enabled
138 # and -DNOFOO=ON if it is disabled.
139 -cmake-utils_useno() { _use_me_now_inverted "" "$@" ; }
140 +cmake-utils_useno() { _cmake_use_me_now_inverted "" "$@" ; }
141
142 # Internal function for modifying hardcoded definitions.
143 # Removes dangerous definitions that override Gentoo settings.
144 -_modify-cmakelists() {
145 +_cmake_modify-cmakelists() {
146 debug-print-function ${FUNCNAME} "$@"
147
148 # Only edit the files once
149 @@ -448,7 +448,7 @@ enable_cmake-utils_src_configure() {
150 done
151 fi
152
153 - _check_build_dir
154 + _cmake_check_build_dir
155
156 # check if CMakeLists.txt exist and if no then die
157 if [[ ! -e ${CMAKE_USE_DIR}/CMakeLists.txt ]] ; then
158 @@ -459,7 +459,7 @@ enable_cmake-utils_src_configure() {
159 fi
160
161 # Remove dangerous things.
162 - _modify-cmakelists
163 + _cmake_modify-cmakelists
164
165 # Fix xdg collision with sandbox
166 local -x XDG_CONFIG_HOME="${T}"
167 @@ -592,7 +592,7 @@ enable_cmake-utils_src_configure() {
168 local cmakeargs=(
169 ${warn_unused_cli}
170 -C "${common_config}"
171 - -G "$(_generator_to_use)"
172 + -G "$(_cmake_generator_to_use)"
173 -DCMAKE_INSTALL_PREFIX="${EPREFIX}${PREFIX}"
174 "${mycmakeargs_local[@]}"
175 -DCMAKE_BUILD_TYPE="${CMAKE_BUILD_TYPE}"
176 @@ -641,11 +641,11 @@ _ninjaopts_from_makeopts() {
177 export NINJAOPTS="${ninjaopts[*]}"
178 }
179
180 -# @FUNCTION: ninja_src_make
181 +# @FUNCTION: _cmake_ninja_src_make
182 # @INTERNAL
183 # @DESCRIPTION:
184 # Build the package using ninja generator
185 -ninja_src_make() {
186 +_cmake_ninja_src_make() {
187 debug-print-function ${FUNCNAME} "$@"
188
189 [[ -e build.ninja ]] || die "build.ninja not found. Error during configure stage."
190 @@ -662,11 +662,11 @@ ninja_src_make() {
191 "$@" || die
192 }
193
194 -# @FUNCTION: emake_src_make
195 +# @FUNCTION: _cmake_emake_src_make
196 # @INTERNAL
197 # @DESCRIPTION:
198 # Build the package using make generator
199 -emake_src_make() {
200 +_cmake_emake_src_make() {
201 debug-print-function ${FUNCNAME} "$@"
202
203 [[ -e Makefile ]] || die "Makefile not found. Error during configure stage."
204 @@ -686,10 +686,10 @@ emake_src_make() {
205 cmake-utils_src_make() {
206 debug-print-function ${FUNCNAME} "$@"
207
208 - _check_build_dir
209 + _cmake_check_build_dir
210 pushd "${BUILD_DIR}" > /dev/null || die
211
212 - ${CMAKE_MAKEFILE_GENERATOR}_src_make "$@"
213 + _cmake_${CMAKE_MAKEFILE_GENERATOR}_src_make "$@"
214
215 popd > /dev/null || die
216 }
217 @@ -697,7 +697,7 @@ cmake-utils_src_make() {
218 enable_cmake-utils_src_test() {
219 debug-print-function ${FUNCNAME} "$@"
220
221 - _check_build_dir
222 + _cmake_check_build_dir
223 pushd "${BUILD_DIR}" > /dev/null || die
224 [[ -e CTestTestfile.cmake ]] || { echo "No tests found. Skipping."; return 0 ; }
225
226 @@ -728,7 +728,7 @@ enable_cmake-utils_src_test() {
227 enable_cmake-utils_src_install() {
228 debug-print-function ${FUNCNAME} "$@"
229
230 - _check_build_dir
231 + _cmake_check_build_dir
232 pushd "${BUILD_DIR}" > /dev/null || die
233 DESTDIR="${D}" ${CMAKE_MAKEFILE_GENERATOR} install "$@" || die "died running ${CMAKE_MAKEFILE_GENERATOR} install"
234 popd > /dev/null || die
235 @@ -742,7 +742,7 @@ enable_cmake-utils_src_install() {
236 # @DESCRIPTION:
237 # Apply ebuild and user patches.
238 cmake-utils_src_prepare() {
239 - _execute_optionally "src_prepare" "$@"
240 + _cmake_execute_optionally "src_prepare" "$@"
241 }
242
243 # @FUNCTION: cmake-utils_src_configure
244 @@ -750,7 +750,7 @@ cmake-utils_src_prepare() {
245 # General function for configuring with cmake. Default behaviour is to start an
246 # out-of-source build.
247 cmake-utils_src_configure() {
248 - _execute_optionally "src_configure" "$@"
249 + _cmake_execute_optionally "src_configure" "$@"
250 }
251
252 # @FUNCTION: cmake-utils_src_compile
253 @@ -758,25 +758,25 @@ cmake-utils_src_configure() {
254 # General function for compiling with cmake.
255 # Automatically detects the build type. All arguments are passed to emake.
256 cmake-utils_src_compile() {
257 - _execute_optionally "src_compile" "$@"
258 + _cmake_execute_optionally "src_compile" "$@"
259 }
260
261 # @FUNCTION: cmake-utils_src_test
262 # @DESCRIPTION:
263 # Function for testing the package. Automatically detects the build type.
264 cmake-utils_src_test() {
265 - _execute_optionally "src_test" "$@"
266 + _cmake_execute_optionally "src_test" "$@"
267 }
268
269 # @FUNCTION: cmake-utils_src_install
270 # @DESCRIPTION:
271 # Function for installing the package. Automatically detects the build type.
272 cmake-utils_src_install() {
273 - _execute_optionally "src_install" "$@"
274 + _cmake_execute_optionally "src_install" "$@"
275 }
276
277 # Optionally executes phases based on WANT_CMAKE variable/USE flag.
278 -_execute_optionally() {
279 +_cmake_execute_optionally() {
280 local phase="$1" ; shift
281 if [[ ${WANT_CMAKE} = always ]]; then
282 enable_cmake-utils_${phase} "$@"
283 --
284 2.4.10