| 1 |
On Wed, Feb 16, 2022 at 06:58:20PM +0100, Andreas Sturmlechner wrote: |
| 2 |
> I'm not sure what this variable is about, but we gotta fix it. |
| 3 |
|
| 4 |
Mentioned this in the bug too, but it's like MYMESONARGS and |
| 5 |
EXTRA_ECONF. Not documented but it's still spread around by |
| 6 |
word of mouth and sometime used by devs too when asking users |
| 7 |
to try options ("does it work with MYCMAKEARGS=-DFIX emerge ...") |
| 8 |
|
| 9 |
Any ebuilds using it directly (e.g. pcsx2) is a bug. |
| 10 |
|
| 11 |
> ...and rather drop on next EAPI bump. |
| 12 |
|
| 13 |
May result in some annoyed users that will ask for it back, not |
| 14 |
that I think the use is that widespread unlike EXTRA_ECONF. |
| 15 |
|
| 16 |
> - "${MYCMAKEARGS}" |
| 17 |
> ) |
| 18 |
> |
| 19 |
> + if [[ -n ${MYCMAKEARGS} ]] ; then |
| 20 |
> + cmakeargs+=( "${MYCMAKEARGS}" ) |
| 21 |
> + fi |
| 22 |
> + |
| 23 |
|
| 24 |
Better fix would've been to remove the quotes I think, so that it |
| 25 |
splits arguments and doesn't pass a literal empty "" string. |
| 26 |
|
| 27 |
i.e. users could MYCMAKEARGS="-DARG1=yes -DARG2=no" through package.env |
| 28 |
|
| 29 |
-- |
| 30 |
ionen |
Archives