Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: ulm@g.o
Subject: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type.
Date: Wed, 26 Feb 2014 15:34:51
Message-Id: 20140226163436.22f1c03a@pomiot.lan
In Reply to: Re: [gentoo-dev] [PATCH git-r3 09/10] Add EGIT_MIN_CLONE_TYPE to support ebuilds requiring greater clone type. by Ulrich Mueller
1 Dnia 2014-02-26, o godz. 16:29:54
2 Ulrich Mueller <ulm@g.o> napisał(a):
3
4 > In _git-r3_env_setup():
5 >
6 > > + single)
7 > > + if [[ ${EGIT_CLONE_TYPE} == shallow ]]; then
8 > > + ewarn "git-r3: ebuild needs to be cloned in 'single' mode, adjusting"
9 > > + EGIT_CLONE_TYPE=single
10 > > + fi
11 > > + ;;
12 > > + mirror)
13 > > + if [[ ${EGIT_CLONE_TYPE} != mirror ]]; then
14 > > + ewarn "git-r3: ebuild needs to be cloned in 'mirror' mode, adjusting"
15 >
16 > This is part of normal operation, so maybe downgrade these ewarns to
17 > elog? There's nothing the user can do to suppress these warnings,
18 > apart from changing his global setting for the clone type, which we
19 > won't want him to do.
20
21 Seems fine. Maybe even 'einfo'?
22
23 --
24 Best regards,
25 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature